Re: [PATCH] nbd: restrict sockets to TCP and UDP
- To: Eric Dumazet <edumazet@google.com>
- Cc: Josef Bacik <josef@toxicpanda.com>, Jens Axboe <axboe@kernel.dk>, linux-kernel <linux-kernel@vger.kernel.org>, netdev@vger.kernel.org, Eric Dumazet <eric.dumazet@gmail.com>, syzbot+e1cd6bd8493060bd701d@syzkaller.appspotmail.com, Mike Christie <mchristi@redhat.com>, "Richard W.M. Jones" <rjones@redhat.com>, Yu Kuai <yukuai1@huaweicloud.com>, linux-block@vger.kernel.org, nbd@other.debian.org
- Subject: Re: [PATCH] nbd: restrict sockets to TCP and UDP
- From: Pavel Machek <pavel@ucw.cz>
- Date: Tue, 18 Nov 2025 18:56:33 +0100
- Message-id: <aRyzUc/WndKJBAz0@duo.ucw.cz>
- In-reply-to: <20250909132243.1327024-1-edumazet@google.com>
- References: <20250909132243.1327024-1-edumazet@google.com>
Hi!
> Recently, syzbot started to abuse NBD with all kinds of sockets.
>
> Commit cf1b2326b734 ("nbd: verify socket is supported during setup")
> made sure the socket supported a shutdown() method.
>
> Explicitely accept TCP and UNIX stream sockets.
Note that running nbd server and client on same machine is not safe in
read-write mode. It may deadlock under low memory conditions.
Thus I'm not sure if we should accept UNIX sockets.
Best regards,
Pavel
--
I don't work for Nazis and criminals, and neither should you.
Boycott Putin, Trump, Netanyahu and Musk!
Attachment:
signature.asc
Description: PGP signature
Reply to: