Re: [PATCH 06/14] sd: add a sd_disable_discard helper
- To: Christoph Hellwig <hch@lst.de>
- Cc: Jens Axboe <axboe@kernel.dk>, "Martin K. Petersen" <martin.petersen@oracle.com>, Richard Weinberger <richard@nod.at>, Anton Ivanov <anton.ivanov@cambridgegreys.com>, Johannes Berg <johannes@sipsolutions.net>, Josef Bacik <josef@toxicpanda.com>, Ilya Dryomov <idryomov@gmail.com>, Dongsheng Yang <dongsheng.yang@easystack.cn>, Roger Pau Monné <roger.pau@citrix.com>, linux-um@lists.infradead.org, linux-block@vger.kernel.org, nbd@other.debian.org, ceph-devel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-scsi@vger.kernel.org, Bart Van Assche <bvanassche@acm.org>, Damien Le Moal <dlemoal@kernel.org>
- Subject: Re: [PATCH 06/14] sd: add a sd_disable_discard helper
- From: "Martin K. Petersen" <martin.petersen@oracle.com>
- Date: Thu, 13 Jun 2024 21:41:58 -0400
- Message-id: <[🔎] yq14j9wti5b.fsf@ca-mkp.ca.oracle.com>
- In-reply-to: <20240531074837.1648501-7-hch@lst.de> (Christoph Hellwig's message of "Fri, 31 May 2024 09:48:01 +0200")
- References: <20240531074837.1648501-1-hch@lst.de> <20240531074837.1648501-7-hch@lst.de>
Christoph,
> Add helper to disable discard when it is not supported and use it
> instead of sd_config_discard in the I/O completion handler. This avoids
> touching more fields than required in the I/O completion handler and
> prepares for converting sd to use the atomic queue limits API.
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
Reply to: