Re: [PATCH 02/26] sd: move zone limits setup out of sd_read_block_characteristics
- To: Damien Le Moal <dlemoal@kernel.org>
- Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>, Geert Uytterhoeven <geert@linux-m68k.org>, Richard Weinberger <richard@nod.at>, Philipp Reisner <philipp.reisner@linbit.com>, Lars Ellenberg <lars.ellenberg@linbit.com>, Christoph Böhmwalder <christoph.boehmwalder@linbit.com>, Josef Bacik <josef@toxicpanda.com>, Ming Lei <ming.lei@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Jason Wang <jasowang@redhat.com>, Roger Pau Monné <roger.pau@citrix.com>, Alasdair Kergon <agk@redhat.com>, Mike Snitzer <snitzer@kernel.org>, Mikulas Patocka <mpatocka@redhat.com>, Song Liu <song@kernel.org>, Yu Kuai <yukuai3@huawei.com>, Vineeth Vijayan <vneethv@linux.ibm.com>, "Martin K. Petersen" <martin.petersen@oracle.com>, linux-m68k@lists.linux-m68k.org, linux-um@lists.infradead.org, drbd-dev@lists.linbit.com, nbd@other.debian.org, linuxppc-dev@lists.ozlabs.org, ceph-devel@vger.kernel.org, virtualization@lists.linux.dev, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, dm-devel@lists.linux.dev, linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, nvdimm@lists.linux.dev, linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-block@vger.kernel.org
- Subject: Re: [PATCH 02/26] sd: move zone limits setup out of sd_read_block_characteristics
- From: Christoph Hellwig <hch@lst.de>
- Date: Wed, 12 Jun 2024 06:45:58 +0200
- Message-id: <[🔎] 20240612044558.GA26468@lst.de>
- In-reply-to: <[🔎] 40ca8052-6ac1-4c1b-8c39-b0a7948839f8@kernel.org>
- References: <[🔎] 20240611051929.513387-1-hch@lst.de> <[🔎] 20240611051929.513387-3-hch@lst.de> <[🔎] 40ca8052-6ac1-4c1b-8c39-b0a7948839f8@kernel.org>
On Tue, Jun 11, 2024 at 02:51:24PM +0900, Damien Le Moal wrote:
> > - if (!sd_is_zoned(sdkp))
> > + if (!sd_is_zoned(sdkp)) {
> > + lim->zoned = false;
>
> Maybe we should clear the other zone related limits here ? If the drive is
> reformatted/converted from SMR to CMR (FORMAT WITH PRESET), the other zone
> limits may be set already, no ?
Yes, but we would not end up here. The device type is constant over
the struct of the scsi_device and we'd have to fully reprobe it.
So we don't need to clear any flags, including the actual zoned flag
here.
Reply to: