Re: [PATCH 02/12] block: take io_opt and io_min into account for max_sectors
- To: Ilya Dryomov <idryomov@gmail.com>
- Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>, "Martin K. Petersen" <martin.petersen@oracle.com>, Richard Weinberger <richard@nod.at>, Anton Ivanov <anton.ivanov@cambridgegreys.com>, Johannes Berg <johannes@sipsolutions.net>, Josef Bacik <josef@toxicpanda.com>, Dongsheng Yang <dongsheng.yang@easystack.cn>, Roger Pau Monn?? <roger.pau@citrix.com>, linux-um@lists.infradead.org, linux-block@vger.kernel.org, nbd@other.debian.org, ceph-devel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-scsi@vger.kernel.org
- Subject: Re: [PATCH 02/12] block: take io_opt and io_min into account for max_sectors
- From: Christoph Hellwig <hch@lst.de>
- Date: Fri, 31 May 2024 08:56:00 +0200
- Message-id: <[🔎] 20240531065600.GA18681@lst.de>
- In-reply-to: <[🔎] CAOi1vP-VXeOH-kShRKv-b=id1zN9tLiqOo8EKpOWoJuQp_Pm1g@mail.gmail.com>
- References: <[🔎] 20240529050507.1392041-1-hch@lst.de> <[🔎] 20240529050507.1392041-3-hch@lst.de> <[🔎] CAOi1vP-F0FO4WTnrEt7FC-uu2C8NTbejvJQQGdZqT475c2G1jA@mail.gmail.com> <[🔎] 20240531055456.GC17396@lst.de> <[🔎] CAOi1vP-VXeOH-kShRKv-b=id1zN9tLiqOo8EKpOWoJuQp_Pm1g@mail.gmail.com>
On Fri, May 31, 2024 at 08:48:12AM +0200, Ilya Dryomov wrote:
> We should revert io_opt from opts->alloc_size to objset_bytes (I think
> it's what you meant to say but typoed).
Yes, sorry.
> How do you want to handle it? I can put together a patch, send it to
> ceph-devel and it will be picked by linux-next sometime next week. Then
> this patch would grow a contextual conflict and the description would
> need to be updated to not mention a behavior change for rbd anymore.
If that works for you I'd much prefer to include it with this series.
I'd be happy to write it myself.
Reply to: