Re: [PATCH 06/12] sd: simplify the disable case in sd_config_discard

To: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>, "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Richard Weinberger <richard@nod.at>, Anton Ivanov <anton.ivanov@cambridgegreys.com>, Johannes Berg <johannes@sipsolutions.net>, Josef Bacik <josef@toxicpanda.com>, Ilya Dryomov <idryomov@gmail.com>, Dongsheng Yang <dongsheng.yang@easystack.cn>, Roger Pau Monné <roger.pau@citrix.com>, linux-um@lists.infradead.org, linux-block@vger.kernel.org, nbd@other.debian.org, ceph-devel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 06/12] sd: simplify the disable case in sd_config_discard
From: Bart Van Assche <bvanassche@acm.org>
Date: Thu, 30 May 2024 13:02:02 -0700
Message-id: <[🔎] 6d52dd83-0cad-448e-8a22-b6f0e1bcac46@acm.org>
In-reply-to: <[🔎] 20240529050507.1392041-7-hch@lst.de>
References: <[🔎] 20240529050507.1392041-1-hch@lst.de> <[🔎] 20240529050507.1392041-7-hch@lst.de>

On 5/28/24 22:04, Christoph Hellwig wrote:

Fall through to the main call to blk_queue_max_discard_sectors given that
max_blocks has been initialized to zero above instead of duplicating the
call.


Reviewed-by: Bart Van Assche <bvanassche@acm.org>

Reply to:

References:
- convert the SCSI ULDs to the atomic queue limits API
  - From: Christoph Hellwig <hch@lst.de>
- [PATCH 06/12] sd: simplify the disable case in sd_config_discard
  - From: Christoph Hellwig <hch@lst.de>

Prev by Date: Re: [PATCH 05/12] sd: add a sd_disable_write_same helper
Next by Date: Re: [PATCH 08/12] sd: cleanup zoned queue limits initialization
Previous by thread: Re: [PATCH 06/12] sd: simplify the disable case in sd_config_discard
Next by thread: [PATCH 04/12] sd: add a sd_disable_discard helper
Index(es):
- Date
- Thread