Re: [PATCH 5/5] bcache: don't clear the flag that is not set
- To: Chaitanya Kulkarni <kch@nvidia.com>
- Cc: linux-block@vger.kernel.org, linux-bcache@vger.kernel.org, axboe@kernel.dk, josef@toxicpanda.com, minchan@kernel.org, senozhatsky@chromium.org, Kent Overstreet <kent.overstreet@gmail.com>, dlemoal@kernel.org, johannes.thumshirn@wdc.com, bvanassche@acm.org, vincent.fu@samsung.com, akinobu.mita@gmail.com, shinichiro.kawasaki@wdc.com, nbd@other.debian.org
- Subject: Re: [PATCH 5/5] bcache: don't clear the flag that is not set
- From: Coly Li <colyli@suse.de>
- Date: Mon, 24 Apr 2023 18:19:52 +0800
- Message-id: <[🔎] F1D47747-F82A-4395-9B11-8A717BB2D96A@suse.de>
- In-reply-to: <[🔎] 20230424073023.38935-6-kch@nvidia.com>
- References: <20230424073023.38935-1-kch@nvidia.com> <[🔎] 20230424073023.38935-6-kch@nvidia.com>
On Mon, Apr 24, 2023 at 12:30:23AM -0700, Chaitanya Kulkarni wrote:
> QUEUE_FLAG_ADD_RANDOM is not set in bcache_device_init() before we clear
> it. There is no point in clearing the flag that is not set.
> Remove blk_queue_flag_clear() for QUEUE_FLAG_ADD_RANDOM.
>
> Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>
Acked-by: Coly Li <colyli@suse.de>
Thanks.
> ---
> drivers/md/bcache/super.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
> index ba3909bb6bea..7e9d19fd21dd 100644
> --- a/drivers/md/bcache/super.c
> +++ b/drivers/md/bcache/super.c
> @@ -971,7 +971,6 @@ static int bcache_device_init(struct bcache_device *d, unsigned int block_size,
> }
>
> blk_queue_flag_set(QUEUE_FLAG_NONROT, d->disk->queue);
> - blk_queue_flag_clear(QUEUE_FLAG_ADD_RANDOM, d->disk->queue);
>
> blk_queue_write_cache(q, true, true);
>
> --
> 2.40.0
>
--
Coly Li
Reply to: