Re: fix and cleanup discard_alignment handling
- To: Christoph Hellwig <hch@lst.de>
- Cc: Jens Axboe <axboe@kernel.dk>, Richard Weinberger <richard@nod.at>, Johannes Berg <johannes@sipsolutions.net>, Josef Bacik <josef@toxicpanda.com>, "Md. Haris Iqbal" <haris.iqbal@ionos.com>, Jack Wang <jinpu.wang@ionos.com>, "Michael S. Tsirkin" <mst@redhat.com>, Jason Wang <jasowang@redhat.com>, Roger Pau Monné <roger.pau@citrix.com>, Mike Snitzer <snitzer@kernel.org>, Song Liu <song@kernel.org>, Stefan Haberland <sth@linux.ibm.com>, Jan Hoeppner <hoeppner@linux.ibm.com>, "Martin K. Petersen" <martin.petersen@oracle.com>, linux-um@lists.infradead.org, linux-block@vger.kernel.org, nbd@other.debian.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, linux-raid@vger.kernel.org, linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org, dm-devel@redhat.com
- Subject: Re: fix and cleanup discard_alignment handling
- From: "Martin K. Petersen" <martin.petersen@oracle.com>
- Date: Tue, 26 Apr 2022 00:16:21 -0400
- Message-id: <[🔎] yq1tuagv5xw.fsf@ca-mkp.ca.oracle.com>
- In-reply-to: <[🔎] 20220418045314.360785-1-hch@lst.de> (Christoph Hellwig's message of "Mon, 18 Apr 2022 06:53:03 +0200")
- References: <[🔎] 20220418045314.360785-1-hch@lst.de>
Christoph,
> the somewhat confusing name of the discard_alignment queue limit, that
> really is an offset for the discard granularity mislead a lot of
> driver authors to set it to an incorrect value. This series tries to
> fix up all these cases.
Not sure how I ended up with "discard_alignment" when I called the
corresponding I/O parameter "alignment_offset".
Anyway. All this looks good to me.
Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
--
Martin K. Petersen Oracle Linux Engineering
Reply to: