Re: [PATCH 0/9] Add data to datalog, add replay tool, V03

[Wouter Verhelst <w@uter.be>]

On Thu, Mar 03, 2022 at 07:39:04PM +0100, Manfred Spraul wrote:
> On 3/3/22 11:13, Wouter Verhelst wrote:
> > Hi Manfred,
> > 
> > On Fri, Jan 21, 2022 at 06:57:02PM +0100, Manfred Spraul wrote:
> > > Hi,
> > > 
> > > Updated series.
> > > New is:
> > > - Patch 0004: Update proto.md
> > > - Patch 0009: An initial man page.
> > > 
> > > Review feedback is welcome!
> > I had a detailed look today, but didn't have any further feedback.
> > 
> > > And: What else is needed for a new tool?
> > > Should I try to create a test case?
> > A new test case might be useful, yes.
> > 
> > Note that there are two (somewhat old by now) transaction logs in
> > tests/run ("integrity-test.tr" and "integrityhuge-test.tr") that you
> > might want to look at.
> > 
> > It could be useful to update nbd-tester-client to also support the new
> > transaction log format. Currently we just write zeroes, which works but
> > is not ideal; with actual data we might be able to compare checksums etc
> > afterwards.
> 
> Ok, I'll try to look at it in the next few days.

Awesome.

One detail that I just realized I forgot to mention: I merged the patch
series you sent so far, so please rebase onto master.

Thanks,

-- 
     w@uter.{be,co.za}
wouter@{grep.be,fosdem.org,debian.org}