Re: [PATCH 01/10] scsi/sd: use blk_cleanup_queue() insted of put_disk()
- To: Christoph Hellwig <hch@infradead.org>
- Cc: axboe@kernel.dk, martin.petersen@oracle.com, jejb@linux.ibm.com, kbusch@kernel.org, sagi@grimberg.me, adrian.hunter@intel.com, beanhuo@micron.com, ulf.hansson@linaro.org, avri.altman@wdc.com, swboyd@chromium.org, agk@redhat.com, snitzer@redhat.com, josef@toxicpanda.com, hare@suse.de, bvanassche@acm.org, ming.lei@redhat.com, linux-scsi@vger.kernel.org, linux-nvme@lists.infradead.org, linux-mmc@vger.kernel.org, dm-devel@redhat.com, nbd@other.debian.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
- Subject: Re: [PATCH 01/10] scsi/sd: use blk_cleanup_queue() insted of put_disk()
- From: Luis Chamberlain <mcgrof@kernel.org>
- Date: Fri, 27 Aug 2021 11:27:36 -0700
- Message-id: <[🔎] YSkumJBTztoYdzC7@bombadil.infradead.org>
- In-reply-to: <YSSJNTxyLHu/LsNJ@infradead.org>
- References: <20210823202930.137278-1-mcgrof@kernel.org> <20210823202930.137278-2-mcgrof@kernel.org> <YSSJNTxyLHu/LsNJ@infradead.org>
On Tue, Aug 24, 2021 at 06:52:53AM +0100, Christoph Hellwig wrote:
> On Mon, Aug 23, 2021 at 01:29:21PM -0700, Luis Chamberlain wrote:
> > The single put_disk() is useful if you know you're not doing
> > a cleanup after add_disk(), but since we want to add support
> > for that, just use the normal form of blk_cleanup_disk() to
> > cleanup the queue and put the disk.
>
> Hmm, I don't think this is correct. The request_queue is owned by the
> core SCSI code.
Alright, I'll drop this one. For the life of me I can't find the respective
probe call on the scsi layer.
Luis
Reply to: