Re: [PATCH 07/10] md: add error handling support for add_disk()
- To: Luis Chamberlain <mcgrof@kernel.org>
- Cc: axboe@kernel.dk, martin.petersen@oracle.com, jejb@linux.ibm.com, kbusch@kernel.org, sagi@grimberg.me, adrian.hunter@intel.com, beanhuo@micron.com, ulf.hansson@linaro.org, avri.altman@wdc.com, swboyd@chromium.org, agk@redhat.com, snitzer@redhat.com, josef@toxicpanda.com, hch@infradead.org, hare@suse.de, bvanassche@acm.org, ming.lei@redhat.com, linux-scsi@vger.kernel.org, linux-nvme@lists.infradead.org, linux-mmc@vger.kernel.org, dm-devel@redhat.com, nbd@other.debian.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
- Subject: Re: [PATCH 07/10] md: add error handling support for add_disk()
- From: Christoph Hellwig <hch@infradead.org>
- Date: Tue, 24 Aug 2021 07:15:56 +0100
- Message-id: <[🔎] YSSOnEiPvCHZXVpb@infradead.org>
- In-reply-to: <20210823202930.137278-8-mcgrof@kernel.org>
- References: <20210823202930.137278-1-mcgrof@kernel.org> <20210823202930.137278-8-mcgrof@kernel.org>
On Mon, Aug 23, 2021 at 01:29:27PM -0700, Luis Chamberlain wrote:
> We never checked for errors on add_disk() as this function
> returned void. Now that this is fixed, use the shiny new
> error handling.
>
> We just do the unwinding of what was not done before, and are
> sure to unlock prior to bailing.
>
> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reply to: