Re: [PATCH 05/10] nvme: add error handling support for add_disk()
- To: Luis Chamberlain <mcgrof@kernel.org>
- Cc: axboe@kernel.dk, martin.petersen@oracle.com, jejb@linux.ibm.com, kbusch@kernel.org, sagi@grimberg.me, adrian.hunter@intel.com, beanhuo@micron.com, ulf.hansson@linaro.org, avri.altman@wdc.com, swboyd@chromium.org, agk@redhat.com, snitzer@redhat.com, josef@toxicpanda.com, hch@infradead.org, hare@suse.de, bvanassche@acm.org, ming.lei@redhat.com, linux-scsi@vger.kernel.org, linux-nvme@lists.infradead.org, linux-mmc@vger.kernel.org, dm-devel@redhat.com, nbd@other.debian.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
- Subject: Re: [PATCH 05/10] nvme: add error handling support for add_disk()
- From: Christoph Hellwig <hch@infradead.org>
- Date: Tue, 24 Aug 2021 07:09:37 +0100
- Message-id: <[🔎] YSSNIaYpUhrkvC+J@infradead.org>
- In-reply-to: <20210823202930.137278-6-mcgrof@kernel.org>
- References: <20210823202930.137278-1-mcgrof@kernel.org> <20210823202930.137278-6-mcgrof@kernel.org>
On Mon, Aug 23, 2021 at 01:29:25PM -0700, Luis Chamberlain wrote:
> + rc = device_add_disk(ctrl->device, ns->disk, nvme_ns_id_attr_groups);
> + if (rc)
> + goto out_cleanup_ns_from_list;
> +
Nit: no real need for the rc variable here as we never use the actual
value.
> if (!nvme_ns_head_multipath(ns->head))
> nvme_add_ns_cdev(ns);
>
> @@ -3785,6 +3789,10 @@ static void nvme_alloc_ns(struct nvme_ctrl *ctrl, unsigned nsid,
>
> return;
>
> + out_cleanup_ns_from_list:
> + down_write(&ctrl->namespaces_rwsem);
> + list_del_init(&ns->list);
> + up_write(&ctrl->namespaces_rwsem);
This also needs to do a nvme_put_ctrl.
Reply to: