Re: [PATCH 23/24] virtio-blk: remove a spurious call to revalidate_disk_size
- To: Christoph Hellwig <hch@lst.de>
- Cc: Jens Axboe <axboe@kernel.dk>, Justin Sanders <justin@coraid.com>, Josef Bacik <josef@toxicpanda.com>, Ilya Dryomov <idryomov@gmail.com>, Jack Wang <jinpu.wang@cloud.ionos.com>, Jason Wang <jasowang@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, Roger Pau Monné <roger.pau@citrix.com>, Minchan Kim <minchan@kernel.org>, Mike Snitzer <snitzer@redhat.com>, Song Liu <song@kernel.org>, "Martin K. Petersen" <martin.petersen@oracle.com>, dm-devel@redhat.com, linux-block@vger.kernel.org, drbd-dev@lists.linbit.com, nbd@other.debian.org, ceph-devel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-raid@vger.kernel.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, linux-fsdevel@vger.kernel.org
- Subject: Re: [PATCH 23/24] virtio-blk: remove a spurious call to revalidate_disk_size
- From: "Michael S. Tsirkin" <mst@redhat.com>
- Date: Mon, 9 Nov 2020 06:30:10 -0500
- Message-id: <[🔎] 20201109063004-mutt-send-email-mst@kernel.org>
- In-reply-to: <20201106190337.1973127-24-hch@lst.de>
- References: <20201106190337.1973127-1-hch@lst.de> <20201106190337.1973127-24-hch@lst.de>
On Fri, Nov 06, 2020 at 08:03:35PM +0100, Christoph Hellwig wrote:
> revalidate_disk_size just updates the block device size from the disk
> size. Thus calling it from revalidate_disk_size doesn't actually do
> anything.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> drivers/block/virtio_blk.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
> index 3e812b4c32e669..145606dc52db1e 100644
> --- a/drivers/block/virtio_blk.c
> +++ b/drivers/block/virtio_blk.c
> @@ -598,7 +598,6 @@ static void virtblk_update_cache_mode(struct virtio_device *vdev)
> struct virtio_blk *vblk = vdev->priv;
>
> blk_queue_write_cache(vblk->disk->queue, writeback, false);
> - revalidate_disk_size(vblk->disk, true);
> }
>
> static const char *const virtblk_cache_types[] = {
> --
> 2.28.0
Reply to: