Re: [PATCH] nbd: make the config put is called before the notifying the waiter

To: xiubli@redhat.com, axboe@kernel.dk
Cc: linux-block@vger.kernel.org, nbd@other.debian.org
Subject: Re: [PATCH] nbd: make the config put is called before the notifying the waiter
From: Josef Bacik <josef@toxicpanda.com>
Date: Wed, 14 Oct 2020 13:33:08 -0400
Message-id: <[🔎] 454c2a43-a0cd-68f9-80ec-172d4bded068@toxicpanda.com>
In-reply-to: <[🔎] 20201014024514.112822-1-xiubli@redhat.com>
References: <[🔎] 20201014024514.112822-1-xiubli@redhat.com>

On 10/13/20 10:45 PM, xiubli@redhat.com wrote:

From: Xiubo Li <xiubli@redhat.com>

There has one race case for ceph's rbd-nbd tool. When do mapping
it may fail with EBUSY from ioctl(nbd, NBD_DO_IT), but actually
the nbd device has already unmaped.

It dues to if just after the wake_up(), the recv_work() is scheduled
out and defers calling the nbd_config_put(), though the map process
has exited the "nbd->recv_task" is not cleared.

Signed-off-by: Xiubo Li <xiubli@redhat.com>


Reviewed-by: Josef Bacik <josef@toxicpanda.com>

Thanks,

Josef

Reply to:

References:
- [PATCH] nbd: make the config put is called before the notifying the waiter
  - From: xiubli@redhat.com

Prev by Date: [PATCH] nbd: make the config put is called before the notifying the waiter
Next by Date: Re: [PATCH] nbd: make the config put is called before the notifying the waiter
Previous by thread: [PATCH] nbd: make the config put is called before the notifying the waiter
Next by thread: Re: [PATCH] nbd: make the config put is called before the notifying the waiter
Index(es):
- Date
- Thread