Re: [PATCH 1/3] nbd: fix connection timed out error after reconnecting to server

To: Yao Liu <yotta.liu@ucloud.cn>
Cc: Josef Bacik <josef@toxicpanda.com>, Jens Axboe <axboe@kernel.dk>, linux-block@vger.kernel.org, nbd@other.debian.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] nbd: fix connection timed out error after reconnecting to server
From: Josef Bacik <josef@toxicpanda.com>
Date: Fri, 24 May 2019 09:07:42 -0400
Message-id: <[🔎] 20190524130740.zfypc2j3q5e3gryr@MacBook-Pro-91.local.dhcp.thefacebook.com>
In-reply-to: <[🔎] 1558691036-16281-1-git-send-email-yotta.liu@ucloud.cn>
References: <[🔎] 1558691036-16281-1-git-send-email-yotta.liu@ucloud.cn>

On Fri, May 24, 2019 at 05:43:54PM +0800, Yao Liu wrote:
> Some I/O requests that have been sent succussfully but have not yet been
> replied won't be resubmitted after reconnecting because of server restart,
> so we add a list to track them.
> 
> Signed-off-by: Yao Liu <yotta.liu@ucloud.cn>

Nack, this is what the timeout stuff is supposed to handle.  The commands will
timeout and we'll resubmit them if we have alive sockets.  Thanks,

Josef

Reply to:

Follow-Ups:
- Re: Re: [PATCH 1/3] nbd: fix connection timed out error after reconnecting to server
  - From: Yao Liu <yotta.liu@ucloud.cn>

References:
- [PATCH 1/3] nbd: fix connection timed out error after reconnecting to server
  - From: Yao Liu <yotta.liu@ucloud.cn>

Prev by Date: [PATCH 1/3] nbd: fix connection timed out error after reconnecting to server
Next by Date: Re: [PATCH 2/3] nbd: notify userland even if nbd has already disconnected
Previous by thread: Re: [PATCH 2/3] nbd: notify userland even if nbd has already disconnected
Next by thread: Re: Re: [PATCH 1/3] nbd: fix connection timed out error after reconnecting to server
Index(es):
- Date
- Thread