[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH v2] proto: add xNBD command NBD_CMD_CACHE to the spec



On 05/17/2018 08:53 AM, Wouter Verhelst wrote:
Hi Eric,

Sorry for not following up on this sooner (and thanks for nudging me)


I think that rather than rubber-stamping "let's send things and see what
happens", it makes more sense to document that there are current
implementations which do work that way, but that we don't recommend
that. As in:

(...); however, note that implementations exist which support the
command even without advertising this bit (...)

In the long term, I would prefer that we don't add new implementations
which behave in this manner, while not immediately causing the existing
implementation (i.e., xnbd) to suddenly no longer be compliant. This
wording does do that.

[...]
+* `NBD_CMD_CACHE` (5)
[...]
+    A client MAY attempt to send a cache request even when
+    `NBD_FLAG_SEND_CACHE` was not set in the transmission flags field,

"Note that client implementations exist which attempt to send a cache
request even when (...)"

+    however, in that case, it MUST NOT use any command flags.  A

"but these implementations do not use any command flags."

other than that, looks good to me.

Thanks for the wording improvements. I've gone ahead and pushed this one into the repository.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


Reply to: