Re: [Nbd] [PATCH] nbd: don't leak nbd_config
- To: Jens Axboe <axboe@...2204...>
- Cc: Josef Bacik <jbacik@...2204...>, nbd-general@lists.sourceforge.net, linux-block@...25..., Josef Bacik <josef@...2877...>
- Subject: Re: [Nbd] [PATCH] nbd: don't leak nbd_config
- From: Ilya Dryomov <idryomov@...17...>
- Date: Tue, 23 May 2017 16:27:56 +0200
- Message-id: <CAOi1vP-MEe6deZzwHt1btXALrDshwcxM79ZrG0uaGd1wRV_xWA@...18...>
- In-reply-to: <8e9d481e-462e-c3f7-8c35-d80f87d1de9a@...2204...>
- References: <1495535911-29036-1-git-send-email-idryomov@...17...> <20170523141445.GA1568@...2930...> <8e9d481e-462e-c3f7-8c35-d80f87d1de9a@...2204...>
On Tue, May 23, 2017 at 4:16 PM, Jens Axboe <axboe@...2204...> wrote:
> On 05/23/2017 08:14 AM, Josef Bacik wrote:
>> On Tue, May 23, 2017 at 12:38:31PM +0200, Ilya Dryomov wrote:
>>> nbd_config is allocated in nbd_alloc_config(), but never freed.
>>>
>>> Fixes: 5ea8d10802ec ("nbd: separate out the config information")
>>> Signed-off-by: Ilya Dryomov <idryomov@...17...>
>>> ---
>>> drivers/block/nbd.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>
>> Oops, thanks Ilya
>>
>> Reviewed-by: Josef Bacik <jbacik@...2204...>
>
> Since config is referenced, why isn't this done in nbd_config_put()
> instead?
Josef's 5ea8d10802ec added that nbd->config = NULL to nbd_reset(), so
I followed his lead. It could be done nbd_config_put() -- nbd_reset()
call in nbd_dev_add() looks like a no-op to me. Josef?
Thanks,
Ilya
Reply to: