On 10/19/2017 12:57 PM, Wouter Verhelst wrote: > On Wed, Oct 18, 2017 at 04:50:18PM -0500, Eric Blake wrote: >> Some options, like NBD_OPT_STARTTLS or the experimental >> NBD_OPT_STRUCTURED_REPLY, only need to be sent once, so >> clients should not expect any particular server behavior >> if they mistakenly send the option again. Document this >> once up-front, rather than repeating it for every option >> that falls in this category. >> >> Signed-off-by: Eric Blake <eblake@redhat.com> >> --- >> > LGTM. Please try out your new commit rights ;-) The commit is now in, so it looks like the permission changes worked. Of course, with this commit in, I need to rework the first hunk of the 'structured-reply: Tweak some protocol requirements' patch, so I'll prepare a v2 of that (probably easier if I first follow through with my plans of syncing master into the various live extension-* branches). -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature