[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [Nbd] [PATCH] nbd: clear disconnected on reconnect

On 07/25/2017 11:31 AM, josef@...2877... wrote:
> From: Josef Bacik <jbacik@...2204...>
> If our device loses its connection for longer than the dead timeout we
> will set NBD_DISCONNECTED in order to quickly fail any pending IO's that
> flood in after the IO's that were waiting during the dead timer.
> However if we re-connect at some point in the future we'll still see
> this DISCONNECTED flag set if we then lose our connection again after
> that, which means we won't get notifications for our newly lost
> connections.  Fix this by just clearing the DISCONNECTED flag on
> reconnect in order to make sure everything works as it's supposed to.

Will add for 4.13. Any chance that you can write blktests regression
tests for some of the bugs that you are fixing for nbd? Would be nice
to have that be part of the regular regression suite.

Jens Axboe

Reply to: