Re: [Nbd] [PATCH 1/3] nbd: allow multiple disconnects to be sent
On Mon, Jul 24, 2017 at 10:08:21PM +0200, Wouter Verhelst wrote:
> On Fri, Jul 21, 2017 at 10:48:13AM -0400, josef@...2877... wrote:
> > From: Josef Bacik <jbacik@...2204...>
> >
> > There's no reason to limit ourselves to one disconnect message per
> > socket. Sometimes networks do strange things, might as well let
> > sysadmins hit the panic button as much as they want.
>
> The protocol spec is pretty clear that any requests sent after the
> disconnect request was sent out are not guaranteed to be processed
> anymore.
>
> Doesn't this allow more requests to be sent out? Or is the
> NBD_DISCONNECT_REQUESTED flag enough to make that impossible?
>
This just allows users to call the disconnect ioctl/netlink thing multiple times
and have it send the DISCONNECT command if they want. We've had problems with
our in-hosue nbd server missing messages, and it's just a pain to have to
unstuck it because the server messed up. It's just for the rare case the server
is being weird, not because we expect/guarantee that subsequent disconnect
commands will be processed. Thanks,
Josef
Reply to: