Re: [Nbd] [PATCH] build: Fix build with older gcc

[Wouter Verhelst <w@...112...>]

Hi Eric,

On Thu, Feb 16, 2017 at 04:47:06PM -0600, Eric Blake wrote:
> On 12/19/2016 04:15 PM, Eric Blake wrote:
> > gcc 4.4.7 (hello RHEL 6) complains about redefinition of typedefs,
> > as in:
> > 
> > gcc -std=gnu99 -DHAVE_CONFIG_H -I.  -DSYSCONFDIR='"/usr/local/etc"'  -g -O2  -g -O2 -MT nbd_client-buffer.o -MD -MP -MF .deps/nbd_client-buffer.Tpo -c -o nbd_client-buffer.o `test -f 'buffer.c' || echo './'`buffer.c
> > buffer.c:39: error: redefinition of typedef ‘buffer_t’
> > buffer.h:31: note: previous declaration of ‘buffer_t’ was here
> > 
> > The .c file only has to declare the struct being typedef'd, not
> > repeat the typedef declaration.
> > 
> > Signed-off-by: Eric Blake <eblake@...696...>
> > ---
> >  buffer.c        | 4 ++--
> >  crypto-gnutls.c | 4 ++--
> >  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> Ping; this problem is still present.

Sorry, that one fell through the cracks indeed. Has been applied now.

-- 
< ron> I mean, the main *practical* problem with C++, is there's like a dozen
       people in the world who think they really understand all of its rules,
       and pretty much all of them are just lying to themselves too.
 -- #debian-devel, OFTC, 2016-02-12