[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [Nbd] [PATCH] nbd: freeze the queue before making changes

On Mon, 2017-02-06 at 10:54 -0500, Josef Bacik wrote:
> The way we make changes to the NBD device is inherently racey, as we
> could be in the middle of a request and suddenly change the number of
> connections.  In practice this isn't a big deal, but with timeouts we
> have to take the config_lock in order to protect ourselves since it
> is
> important those values don't change.  Fix this by freezing the queue
> before we do any of our device operations.
> Signed-off-by: Josef Bacik <jbacik@...2204...>

Actually nevermind, this messes with my plans around reconnections
since freezing also waits for existing timeouts to fire.  I'll drop
this and fix it a different way.  Thanks,


Reply to: