Re: [Nbd] [PATCH 2/4] miscdevice: add a minor number for nbd-control
> On Jan 21, 2017, at 4:03 AM, Greg KH <gregkh@...1299...> wrote:
>
>> On Fri, Jan 20, 2017 at 04:56:50PM -0500, Josef Bacik wrote:
>> NBD is moving to a loop-control esque way of managing it's device
>> creation and deletion. Reserver a minor number for the new device.
>>
>> Signed-off-by: Josef Bacik <jbacik@...2204...>
>> ---
>> include/linux/miscdevice.h | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/include/linux/miscdevice.h b/include/linux/miscdevice.h
>> index ed30d5d..7e5c140 100644
>> --- a/include/linux/miscdevice.h
>> +++ b/include/linux/miscdevice.h
>> @@ -44,6 +44,7 @@
>> #define MISC_MCELOG_MINOR 227
>> #define HPET_MINOR 228
>> #define FUSE_MINOR 229
>> +#define NBD_CTRL_MINOR 230
>
> Ick, really? Why not just use a dynamic one? What 1990's-based systems
> are you running that you would need a static misc device number for?
>
Honestly I was just doing what loop did, I wasn't sure if there was some administration reason for needing a static minor number. If nobody cares then I can just use a dynamic one. Thanks,
Josef
Reply to: