Re: [Nbd] [PATCH 3/5] nbd: use flags instead of bool
- To: Jens Axboe <axboe@...2204...>, Josef Bacik <jbacik@...2204...>, linux-block@...25..., linux-kernel@...25..., kernel-team@...2204..., mpa@...1897..., nbd-general@lists.sourceforge.net
- Subject: Re: [Nbd] [PATCH 3/5] nbd: use flags instead of bool
- From: Joe Perches <joe@...1529...>
- Date: Fri, 09 Sep 2016 09:15:00 -0700
- Message-id: <1473437700.13672.43.camel@...1529...>
- In-reply-to: <9ddc6c54-72cd-b3d4-d7f3-f96dc33164fc@...2204...>
- References: <1473369130-22986-1-git-send-email-jbacik@...2204...> <1473369130-22986-4-git-send-email-jbacik@...2204...> <1473384038.13672.23.camel@...1529...> <bda72452-8a5f-8a6a-2409-145585ea41f5@...2204...> <1473437068.13672.41.camel@...1529...> <9ddc6c54-72cd-b3d4-d7f3-f96dc33164fc@...2204...>
On Fri, 2016-09-09 at 10:11 -0600, Jens Axboe wrote:
> The variable is called 'runtime_flags' - if that doesn't already tell
> the reader how it's used, then I'd suggest the reader go read something
> else.
>
> I'm all for using established APIs where it makes sense. Declaring a
> bitmap for a few fields isn't that.
Deviating from established APIs makes no sense.
Reply to: