Re: [Nbd] [PATCH 0/4]nbd: fixes for nbd
- To: Markus Pargmann <mpa@...1897...>, nbd-general@lists.sourceforge.net, linux-kernel@...25...
- Cc: "Pranay Kr. Srivastava" <pranjas@...17...>
- Subject: Re: [Nbd] [PATCH 0/4]nbd: fixes for nbd
- From: Pranay Srivastava <pranjas@...17...>
- Date: Mon, 30 May 2016 09:05:46 +0530
- Message-id: <CA+aCy1GORDoKXQyRqCR3zBbZ=b6WfbQS-ZwN5yU=Nk-SGz9UpQ@...18...>
- In-reply-to: <1464089188-6155-1-git-send-email-pranjas@...17...>
- References: <1464089188-6155-1-git-send-email-pranjas@...17...>
Hi
On Tue, May 24, 2016 at 4:56 PM, Pranay Kr. Srivastava
<pranjas@...17...> wrote:
> This patch series fixes the following
>
> 1) fix might_sleep warning on socket shutdown:
> Fix sock_shutdown to avoid calling kernel_sock_shutdown
> while holding spin_lock.
>
> 2)fix various coding standard warnings
> Make shutdown get called in a process context instead, using
> system_wq.
>
> 3) make nbd device wait for its users.
> When a timeout or error occurs then nbd driver simply kills
> the block device. Many filesystem(s) example ext2/ext3 don't
> expect their buffer heads to disappear like that. Fix this
> by making nbd device wait for its users.
>
> 4) use device_attr macros for sysfs attribute
> use DEVICE_ATTR_RO for sysfs pid attribute.
>
> Pranay Kr. Srivastava (4):
> fix might_sleep warning on socket shutdown.
> fix various coding standard warnings
> make nbd device wait for its users.
> use device_attr macros for sysfs attribute
>
> drivers/block/nbd.c | 150 +++++++++++++++++++++++++++++++++++----------------
> 1 file changed, 105 insertions(+), 45 deletions(-)
>
> --
> 1.7.9.5
>
Can anyone review this?
--
---P.K.S
Reply to: