[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [Nbd] [PATCH] Fix flags processing to avoid bogus read-only export



On Thu, May 05, 2016 at 10:18:24AM +0100, Alex Bligh wrote:
> 
> On 5 May 2016, at 09:59, Wouter Verhelst <w@...112...> wrote:
> 
> >> If people are OK about this, how do I get this upstream?
> > 
> > Well, I'm not going to release updated upstream versions of this, and
> > the most recent version of nbd doesn't expose the bug.
> 
> Sure, it's already fixed upstream :-)
> 
> > However, having
> > that patch in distributions which still ships and older version of nbd
> > does sure sound like a good idea.
> 
> Cool.
> 
> >> I'm happy to file an Ubuntu bug but I'm wondering if Wouter is the
> >> Debian maintainer, and indeed whether we (I?) can simply push it as a
> >> branch.
> > 
> > I am the Debian maintainer, yes. What kind of branch do you mean,
> > though?
> 
> There are branches called 'debian-wheezy', 'debian-jessie' etc.,
> though I don't know what they do.

Oh, right.

They contain the packaging stuff for Debian, for those suites. You'll see a
change there once I have an ack from the stable release managers that this
update will be allowed into Debian.

> I suppose I was thinking
>    git checkout debian-jessie
>    git checkout -b debian-jessie-fixed
>    git am /path/to/patch
>    git push
> 
> Ultimately I don't much care, just that the patch should be somewhere
> in git I would have thought.
> 
> But as you are Debian maintainer, and nbd maintainer, I think you
> probably know better than me how to do this.

Likely :-)

> > I'm thinking it does make sense to push an update to Debian Jessie for
> > this, too. It's a bit of an ugly bug.
> 
> Great.
> 
> Re Ubuntu, I filed an ubuntu bug, and Robbie Basak (Ubuntu) has
> volunteered on IRC to sponsor an SRU to update Trusty.
> 
> https://bugs.launchpad.net/ubuntu/+source/nbd/+bug/1578185
> 
> I'm happy to shepherd this through the Ubuntu process. If
> the Debian and Ubuntu packages are identical or near identical,
> I'll work off your proposed update, rather than putting my
> own patch on that bug.

Your own patch is pretty solid, and "minimal patch" is a virtue for a stable
update, so I'm likely to just copy it for stable :-)

> -- 
> Alex Bligh
> 
> 
> 
> 
> 
> ------------------------------------------------------------------------------
> Find and fix application performance issues faster with Applications Manager
> Applications Manager provides deep performance insights into multiple tiers of
> your business applications. It resolves application problems quickly and
> reduces your MTTR. Get your free trial!
> https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
> _______________________________________________
> Nbd-general mailing list
> Nbd-general@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/nbd-general
> 

-- 
< ron> I mean, the main *practical* problem with C++, is there's like a dozen
       people in the world who think they really understand all of its rules,
       and pretty much all of them are just lying to themselves too.
 -- #debian-devel, OFTC, 2016-02-12



Reply to: