On 04/07/2016 04:30 PM, Alex Bligh wrote: >> >> diff --git a/doc/proto.md b/doc/proto.md >> index f117394..a81b59c 100644 >> --- a/doc/proto.md >> +++ b/doc/proto.md >> @@ -743,6 +743,10 @@ Therefore these commands share common documentation. >> to requests for exports that are unknown. This is so that clients >> that have not negotiated TLS cannot enumerate exports. >> >> + For backwards compatibility, clients should be prepared to also >> + handle `NBD_REP_ERR_UNSUP`. In this case, they should fall back to >> + using `NBD_OPT_EXPORT_NAME`. > > This back compatibility thing is the thing I thought should be a 'MUST' > but you and Wouter think (and I accepted) should be a 'SHOULD'. But > it should not be a 'should'. It's now - well it is > after MAY/SHOULD/MUST patch - a SHOULD elsewhere (search > for 'backwards'. > > So s/should/SHOULD/ in both cases. Patch 1 is my wording tweak (straight motion of that paragraph); patch 2 is what changes s/should/SHOULD/ in the paragraph's new location (part of the conflict resolutions I had to do to get to v6 of your patch). > I'm a bit puzzled as to how that was a lowercase 'should' in the first > place. It's upper case after applying v5 of my SHOULD/MUST/MAY > patch. Just wondering in case there is anything else missed. It's because patch 1/2 is applied _prior_ to your SHOULD/MUST/MAY. I think it's all correct after both patches, in the order supplied in my series. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature