[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [Nbd] [PATCH] Document format of strings in one place, limit to 4096 bytes



On 04/06/2016 02:37 PM, Eric Blake wrote:
> On 04/06/2016 02:27 PM, Wouter Verhelst wrote:
>>
>> Also, most of those strings exist solely to make user interaction
>> easier. In that context, a 4K string is *way* too long; I'm thinking
>> something like 256 seems saner (80 characters, times three because
>> UTF-8, round up to the next power of two).
> 
> For that matter, the existing qemu-nbd server has:
> 

>     if (length > 255) {
>         LOG("Bad length received");
>         goto fail;

Other arbitrary limits that are probably worth documenting for
interoperability: qemu-nbd rejects any NBD_CMD_READ or NBD_CMD_WRITE
with length > 32M.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: