On 04/05/2016 11:57 PM, Denis V. Lunev wrote: >> Looks like there will still be some more conversation and at least a v3 >> needed, but I'll wait a couple days for that to happen so that more >> reviewers can chime in, without being too tired during the review >> process. >> > that looks correct to me. I agree that we should set only one flag > and reject the request with two of them. > Actually this is like "bitmap number", but we have limitation with 32 > numbers only. > > We could specify that the server MUST reply with "all 1" for unknown > flag. This would provide nice forward compatibility. My v2 approach was to define the status so that "all 0" was the safe default (hence, naming the flag "NBD_STATUS_CLEAN" and set to 1 only when no longer dirty, not "NBD_STATUS_DIRTY" where 1 by default is safer). -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature