Re: [Nbd] [Qemu-devel] [PATCH 2/2] NBD proto: add GET_LBA_STATUS extension
- To: Kevin Wolf <kwolf@...696...>, Wouter Verhelst <w@...112...>
- Cc: nbd-general@lists.sourceforge.net, "Denis V. Lunev" <den@...2317...>, Eric Blake <eblake@...696...>, qemu-devel@...530..., Stefan Hajnoczi <stefanha@...696...>
- Subject: Re: [Nbd] [Qemu-devel] [PATCH 2/2] NBD proto: add GET_LBA_STATUS extension
- From: Paolo Bonzini <pbonzini@...696...>
- Date: Tue, 29 Mar 2016 12:25:56 +0200
- Message-id: <56FA5834.4090702@...696...>
- In-reply-to: <20160329093835.GB4600@...2331...>
- References: <1458742562-30624-1-git-send-email-den@...2317...> <1458742562-30624-3-git-send-email-den@...2317...> <20160323175834.GC2467@...3...> <56F3D5C7.9070007@...696...> <56F406E7.4010207@...696...> <56F408D6.2020002@...696...> <20160324155319.GK2870@...3...> <56F4101D.7030603@...696...> <20160324160747.GF4310@...2331...> <20160324164747.GA2902@...3...> <20160329093835.GB4600@...2331...>
On 29/03/2016 11:38, Kevin Wolf wrote:
> > > How about NBD_STATE_HOLE?
> >
> > Both will work, although I like NBD_STATE_TRIM slightly better because
> > it indeed nicely references NBD_CMD_TRIM.
>
> I just thought that "trim" sounds more like an action than a status, and
> while the reason for a hole to exist can be a previous TRIM command,
> another option is that it's an area in an image that just has never been
> written to. In that case "trim" would be a misnomer.
I agree with Kevin. My preference is still on NBD_STATE_ALLOCATED, but
NBD_STATE_HOLE is a fine name as well.
Paolo
Attachment:
signature.asc
Description: OpenPGP digital signature
Reply to: