Re: [Nbd] [PATCH] Fix doc typos
- To: Eric Blake <eblake@...696...>
- Cc: nbd-general@lists.sourceforge.net
- Subject: Re: [Nbd] [PATCH] Fix doc typos
- From: Wouter Verhelst <w@...112...>
- Date: Fri, 25 Mar 2016 09:04:46 +0100
- Message-id: <20160325080445.GA32701@...3...>
- In-reply-to: <1458854835-23729-1-git-send-email-eblake@...696...>
- References: <1458854835-23729-1-git-send-email-eblake@...696...>
Hi Eric,
On Thu, Mar 24, 2016 at 03:27:15PM -0600, Eric Blake wrote:
> Fix the spelling of "beef", and the case of an "NBD_REP" constant.
>
> Signed-off-by: Eric Blake <eblake@...696...>
> ---
>
> I noticed these while reviewing the recent proposed spec additions
> for efficient sparse file handling
>
> doc/proto.md | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/doc/proto.md b/doc/proto.md
> index 463ef8a..6d1cb34 100644
> --- a/doc/proto.md
> +++ b/doc/proto.md
> @@ -21,7 +21,7 @@ an implementational detail of the server.
> In the below protocol descriptions, the label 'C:' is used for messages
> sent by the client, whereas 'S:' is used for messages sent by the
> server). `monotype text` is for literal character data or (when used in
> -comments) constant names, `0xdeadbeaf` is used for literal hex numbers
> +comments) constant names, `0xdeadbeef` is used for literal hex numbers
> (which are always sent in network byte order), and (brackets) are used
> for comments. Anything else is a description of the data that is sent.
>
> @@ -307,7 +307,7 @@ of the newstyle negotiation.
> `NBD_REP_ERR_POLICY`. For backwards compatibility, a client should
> also be prepared to handle `NBD_REP_ERR_UNSUP`. If the client sent
> along any data with the request, the server should send back
> - `nbd_REP_ERR_INVALID`.
> + `NBD_REP_ERR_INVALID`.
>
> This functionality has not yet been implemented by the reference
> implementation, but was implemented by qemu so has been moved out of
Thanks, applied.
--
< ron> I mean, the main *practical* problem with C++, is there's like a dozen
people in the world who think they really understand all of its rules,
and pretty much all of them are just lying to themselves too.
-- #debian-devel, OFTC, 2016-02-12
Reply to: