[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [Nbd] Proposal to merge WRITE_ZEROES extension into master



> On 19 Dec 2016, at 21:54, Eric Blake <eblake@...696...> wrote:
> 
> On 12/19/2016 03:41 PM, Wouter Verhelst wrote:
>> On Thu, Dec 15, 2016 at 12:09:42PM +0100, Wouter Verhelst wrote:
>>> Eric's patch makes -d work again, but disables maxconnections in that
>>> case. I'll need to fix it up; hopefully that'll happen sometime next
>>> week, because otherwise I'll be too late to make the Debian freeze for
>>> stretch, and I'd really like STARTTLS to be in there.
>> 
>> I'm an idiot :-)
>> 
>> When we say "don't fork", that means we cannot handle more than one
>> connection, because we can't fork, and we do fork-per-child.
>> 
>> I'll apply Eric's patch, it's the correct thing to do.
> 
> I'm not sure if I broke the ACL handling in my patch, though, so you'll
> want to double-check that aspect of it (I basically hardcoded -d to mean
> that the ACL check would always succeed).

Yeah that was my reason for not merging it.

--
Alex Bligh




Attachment: signature.asc
Description: Message signed with OpenPGP using GPGMail


Reply to: