Re: [Nbd] [PATCH] build: Allow CFLAGS override during make

[Wouter Verhelst <w@...112...>]

On Thu, Dec 15, 2016 at 10:59:10AM -0600, Eric Blake wrote:
> On 12/15/2016 10:53 AM, Wouter Verhelst wrote:
> > On Wed, Dec 14, 2016 at 04:19:53PM -0600, Eric Blake wrote:
> >> Automake recommends the use of $(CFLAGS), not @CFLAGS@, because
> >> that allows a user to override CFLAGS at make time (with
> >> 'make CFLAGS=-g', for example) rather than being hard-coded to
> >> the CFLAGS in use during configure time.  Use the preferred
> >> substitution style for ALL variables, not just CFLAGS.
> > 
> > Actually, we want to use AM_CFLAGS, which works with older versions of
> > automake, too, IIRC. Given that, I don't think there's much point in converting
> > all the @FOO_CFLAGS@ etc to $() syntax.
> 
> Whether it is $(CFLAGS) or $(AM_CFLAGS) is less important, the point
> remains that automake (including older versions all the way back to the
> automake present on RHEL 5) documents that $(name) is preferred over
> @name@ substitutions in Makefile.am.

Okay, maybe I misremembered that then...

-- 
< ron> I mean, the main *practical* problem with C++, is there's like a dozen
       people in the world who think they really understand all of its rules,
       and pretty much all of them are just lying to themselves too.
 -- #debian-devel, OFTC, 2016-02-12