[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [Nbd] [PATCH] build: Allow CFLAGS override during make



On Wed, Dec 14, 2016 at 04:19:53PM -0600, Eric Blake wrote:
> Automake recommends the use of $(CFLAGS), not @CFLAGS@, because
> that allows a user to override CFLAGS at make time (with
> 'make CFLAGS=-g', for example) rather than being hard-coded to
> the CFLAGS in use during configure time.  Use the preferred
> substitution style for ALL variables, not just CFLAGS.

Actually, we want to use AM_CFLAGS, which works with older versions of
automake, too, IIRC. Given that, I don't think there's much point in converting
all the @FOO_CFLAGS@ etc to $() syntax.

-- 
< ron> I mean, the main *practical* problem with C++, is there's like a dozen
       people in the world who think they really understand all of its rules,
       and pretty much all of them are just lying to themselves too.
 -- #debian-devel, OFTC, 2016-02-12



Reply to: