Re: [Nbd] [PATCH] Further tidy-up on block status
- To: Wouter Verhelst <w@...112...>
- Cc: "nbd-general@lists.sourceforge.net" <nbd-general@lists.sourceforge.net>, Kevin Wolf <kwolf@...696...>, Vladimir Sementsov-Ogievskiy <vsementsov@...2319...>, "qemu-devel@...530..." <qemu-devel@...530...>, "Stefan stefanha@...2321... com" <stefanha@...696...>, Paolo Bonzini <pbonzini@...696...>, "Denis V . Lunev" <den@...2317...>, John Snow <jsnow@...696...>
- Subject: Re: [Nbd] [PATCH] Further tidy-up on block status
- From: Alex Bligh <alex@...872...>
- Date: Thu, 15 Dec 2016 16:32:23 +0000
- Message-id: <78C8A0CB-717D-4925-8AA8-A085DC1F9FB7@...872...>
- In-reply-to: <20161215150312.dmxrxn7ujzq3apy6@...3...>
- References: <31576d46-c0ed-29b9-71a0-5aca1790799a@...2319...> <6D1B30FC-FD7E-474C-A8E3-FD87E7AA1364@...872...> <5e9150ed-2127-f2e8-f9db-a514e8f0ddf8@...2319...> <5E697C22-5FBB-49A2-A018-A6B96E29FE84@...872...> <94ef3ef2-b76f-fa5d-cbaf-8990ce2b1be8@...2319...> <20161214181323.mehzfmlf6z4pyajp@...3...> <D71CECFD-E513-4372-BB54-BF8D8D521292@...872...> <3D392E31-DDA4-4316-B26D-871E94A83935@...872...> <20161214201858.lblzw2ayddidxfyp@...3...> <58F412AB-8A4C-403F-AEE2-D2FB958D447A@...872...> <20161215150312.dmxrxn7ujzq3apy6@...3...>
Wouter,
> This reads a bit awkward. I would do:
>
> s/save that:/except as explained below/
Possibly a British English thing. Will fix.
>> If one or more queries are sent, then the server MUST return
>> those metadata contexts that are available to the client to
>> select on the given export with `NBD_OPT_SET_META_CONTEXT`,
>> and which match one or more of the queries given. The
>> support of wildcarding within the leaf-name portion of
>> the query string is dependent upon the namespace.
>>
>> In either case, however, for any given namespace the
>> server MAY, instead of exhaustively listing every
>> matching context available to select (or every context
>> available to select where no query is given), send
>> sufficient context records back to allow a client with
>> knowledge of the namespace to select any context. Each
>> namespace returned MUST still satisfy the rules for
>> namespaces (i.e. they must begin with the relevant
>> namespace, followed by a colon, then printable non-whitespace
>> UTF-8 characters,
>
> Why restrict to non-whitespace characters? (printable makes sense...)
Because the namespaces and leaf-names are already restricted to
non-whitespace characters. I thought having tabs, line feeds,
returns, em-space, en-space etc. was not particularly useful.
I could be persuaded to relent re spaces.
--
Alex Bligh
Reply to: