[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [Nbd] [PATCH v2 1/6] build: Silence autogen.sh warnings



On 10/18/2016 09:12 AM, Eric Blake wrote:
> On 10/18/2016 06:01 AM, Wouter Verhelst wrote:
> 
>>> Following the advice almost works, except that automake 1.15 still
>>> has a nasty bug (https://debbugs.gnu.org/cgi/bugreport.cgi?bug=13928)
>>> where use of $(foo) in a _SOURCES variable coupled with subdir-objects
>>> creates a directory with a literal name $(foo) rather than the intended
>>> name.  But as long as we only care about $(srcdir) (or parent
>>> directories), the solution is to just not use $(srcdir) in _SOURCES,
>>> and instead open-code the traversal to the desired files.
>>
>> The reason for using $(top_srcdir) is so that VPATH builds don't go
>> bollocks. Did you do a "make distcheck" with this?
> 
> Not yet; will do and report back.

Initial testing: broken before my patches:

checking for GnuTLS... configure: error: Package requirements (gnutls >=
3.3.0) were not met:

Requested 'gnutls >= 3.3.0' but version of GnuTLS is 2.8.5

You'll want to make the new TLS code conditional, and merely disable TLS
rather than fail the entire build if you don't have a new enough library
to rely on.  I might be able to develop that patch too...

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: