[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [Nbd] [PATCH] nbd: convert to blkmq

On 07/01/2016 08:15 AM, Josef Bacik wrote:
This moves NBD over to using blkmq, which allows us to get rid of the NBD
wide queue lock and the async submit kthread.  We will start with 1 hw
queue for now, but I plan to add multiple tcp connection support in the
future and we'll fix how we set the hwqueue's.

Looks pretty clean. I'd get rid of that horrible nbd_find_request() as well, though. Store the request tag in the reply.handle, and then just lookup the request from the tag, if the tag is valid. The resulting request can then be checked for proper state (started).

nbd->active_cmd needs to die as well.

Jens Axboe

Reply to: