Re: [Nbd] [Qemu-devel] [PULL 23/28] nbd: always query export list in fixed new style protocol
- To: Wouter Verhelst <w@...112...>
- Cc: "nbd-general@lists.sourceforge.net" <nbd-general@lists.sourceforge.net>, "Daniel P. Berrange" <berrange@...696...>, "qemu-devel@...530..." <qemu-devel@...530...>, Paolo Bonzini <pbonzini@...696...>
- Subject: Re: [Nbd] [Qemu-devel] [PULL 23/28] nbd: always query export list in fixed new style protocol
- From: "Richard W.M. Jones" <rjones@...696...>
- Date: Sun, 22 May 2016 19:16:25 +0100
- Message-id: <20160522181625.GQ1683@...696...>
- In-reply-to: <20160521215312.GA8497@...3...>
- References: <1455640486-6101-1-git-send-email-pbonzini@...696...> <1455640486-6101-24-git-send-email-pbonzini@...696...> <20160517095339.GD28935@...696...> <573B342E.8030208@...696...> <5ED6FB6F-5023-4833-83F9-B24BD379E2CD@...872...> <573B3E3E.60902@...696...> <B514F1F3-F3D8-4F86-942D-E1D12273762F@...872...> <573B4BB9.50701@...696...> <20160521215312.GA8497@...3...>
On Sat, May 21, 2016 at 11:53:12PM +0200, Wouter Verhelst wrote:
> On Tue, May 17, 2016 at 10:50:01AM -0600, Eric Blake wrote:
> > Option 2: An alternative solution would be to allow nbdkit to fail
> > NBD_OPT_LIST with NBD_REP_ERR_UNSUP, at which point qemu client of 2.6
> > should just ignore the failure and proceed on to NBD_OPT_EXPORT_NAME.
> > It is the fact that it is returning NBD_REP_ACK with 0 names that is
> > giving qemu grief.
>
> I think this makes most sense. If you don't look at export names, you
> effectively don't support them, and you can't be expected to send a list
> of "supported" names, because *everything* is supported (or, put a
> different way, nothing is).
>
> I note that nbdkit has been patched to now send the empty name, which
> is also fine as a way to fix interoperability in this particular case --
nbdkit now fully supports export names via the '-e' option.
This discussion is moot.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines. Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v
Reply to: