On 05/11/2016 03:38 AM, Pranay Srivastava wrote: > > The series contained some checkpatch changes so I had included you as well. > >> know why you are sending them to me), but I know I do not accept patches >> without any changelog text at all in them, as that's just lazy. > > That should be per patch or can appear in a cover letter for the patches? Per patch. However, if it were me, I would not have split into quite so many patches. The mantra is one patch per one fix, but I think it is reasonable to state that "silence all checkpatch warnings" counts as one fix, rather than 16 separate fixes. If you DO consolidate the checkpatch changes into a single patch, then the commit message body should call out a bulleted list of all the changes you are making, as well as a justification why it is worth churning the entire file rather than just making smaller checkpatch fixes in just the areas that your other patches touch. > > Actually I've made more patches in this series after I had sent the > earlier ones, > but the earlier ones are not changed at all. It's only the addition of > newer patches > to the series. The cover letter is a great place to point out how v4 differs from v3, but also to point out which patches are unchanged from v3, to save reviewer's time. So if all you did was add new patches, a cover-letter mention of which patches remain unchanged might be helpful. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature