Re: [Nbd] [PATCH] doc: Cleanups now that we have synchronous haggling
- To: Eric Blake <eblake@...696...>
- Cc: "nbd-general@lists.sourceforge.net" <nbd-general@lists.sourceforge.net>
- Subject: Re: [Nbd] [PATCH] doc: Cleanups now that we have synchronous haggling
- From: Alex Bligh <alex@...872...>
- Date: Fri, 22 Apr 2016 04:48:42 +0100
- Message-id: <DB871EFB-F558-459B-A4F2-4BE6811F34D5@...872...>
- In-reply-to: <1461265669-5940-1-git-send-email-eblake@...696...>
- References: <1461265669-5940-1-git-send-email-eblake@...696...>
Applied, thanks
On 21 Apr 2016, at 20:07, Eric Blake <eblake@...696...> wrote:
> Now that there is at most one in-flight message, we can drop
> some other statements about the server needing to wait to
> process one option while other options are in-flight.
>
> Signed-off-by: Eric Blake <eblake@...696...>
> ---
>
> master branch
>
> doc/proto.md | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/doc/proto.md b/doc/proto.md
> index 78449f6..13af181 100644
> --- a/doc/proto.md
> +++ b/doc/proto.md
> @@ -179,8 +179,6 @@ To fix these two issues, the following changes were implemented:
> field too, though its side of the protocol does not change incompatibly.
> - The client MAY now send other options to the server as appropriate, in
> the generic format for sending an option as described above.
> -- The server MUST NOT send a response to `NBD_OPT_EXPORT_NAME` until all
> - other pending option requests have had their final reply.
> - The server will reply to any option apart from `NBD_OPT_EXPORT_NAME`
> with reply packets in the following format:
>
> @@ -256,7 +254,7 @@ error inbound options until the client gets the hint that it is
> unwelcome, except that if a server believes a client's behaviour
> constitutes a denial of service, it MAY initiate a hard disconnect.
> If the server is in the process of being shut down it MAY
> -error inflight options and SHOULD error further options received
> +error any inflight option and SHOULD error further options received
> (other than an `NBD_OPT_ABORT`) with `NBD_REP_ERR_SHUTDOWN`.
>
> If the client receives `NBD_REP_ERR_SHUTDOWN` it MUST initiate
> --
> 2.5.5
>
>
> ------------------------------------------------------------------------------
> Find and fix application performance issues faster with Applications Manager
> Applications Manager provides deep performance insights into multiple tiers of
> your business applications. It resolves application problems quickly and
> reduces your MTTR. Get your free trial!
> https://ad.doubleclick.net/ddm/clk/302982198;130105516;z
> _______________________________________________
> Nbd-general mailing list
> Nbd-general@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/nbd-general
>
--
Alex Bligh
Reply to: