On 04/19/2016 02:06 AM, Alex Bligh wrote: > Eric, > > I spent some time looking at this and am finding it very difficult > to differentiate between > > a) whitespace changes > b) movement of the text within the document > c) substantive changes. > > Could you break it up into a set of patches that > does each of those separately? Or at least flag the > changes somehow? Yes, I'll break it up and resubmit. > > On the reorganisation, I know the document often has > an overview bit, and the detail later, but it seems > now we are splitting structured replies into > three sections: > > #### Structured reply chunk message > > and > > *Structured replies* > > and > > #### Structured Reply flags > > And the thing defining structured replies comes later. > > This seems a bit strange and now means you need to > hunt *more* around the document. > > To be honest I wasn't fantastically happy with the old layout > where structured replies are described in detail under > NBD_CMD_READ (that's the middle of those). The old layout was while everything was still documented under the extension section. So at this point, we're still debating on how best to place the text within the document for promotion to normative, while at the same time also trying to adjust structured replies to make error replies easier to identify. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature