Eric, On 15 Apr 2016, at 15:10, Eric Blake <eblake@...696...> wrote: > I posted qemu patches a while back, but they need a refresh. Those would be interesting. > You completely ignore NBD_CMD_FLAG_NO_HOLE; you could obey that flag > (when set, do the calloc() here; when cleared, call into the trim code > if you can guarantee that you'll read zero after trims). But if nothing > else, you have a bug for not permitting the NBD_CMD_FLAG_NO_HOLE (even > if you intend to ignore it by ALWAYS operating in no-hole mode, as was > done here). Thanks. I missed that. -- Alex Bligh
Attachment:
signature.asc
Description: Message signed with OpenPGP using GPGMail