On 04/07/2016 02:12 PM, Alex Bligh wrote: > This commit adds documentation for NBD_CMD_CLOSE which provides a > safer way for the client to close connections, and indicates > unambiguously to the server and client whether a close is safe. > > Signed-off-by: Alex Bligh <alex@...872...> > --- > doc/proto.md | 72 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 72 insertions(+) > > This applies on top of: > [PATCHv5] docs/proto.md: Clarify SHOULD / MUST / MAY etc > so it can take advantage of the 'exposes' language. Should we be sticking this in the Experimental Extensions section, until we have an implementation? > @@ -638,6 +645,71 @@ The following request types exist: > > Defined by the experimental `WRITE_ZEROES` extension; see below. > > +* `NBD_CMD_CLOSE` (7) > + > + A close request. The server MUST handle all outstanding That is, I suspect we need "Defined by the experimental `CLOSE` extension; see below." here, and the bulk of the text later in the document. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature