Re: [Nbd] [PATCH 2/5] nbd: Remove signal usage
Hi Markus,
this looks great!
Reviewed-by: Christoph Hellwig <hch@...1995...>
One thing I noticed, which might be a good cleanup in the future:
> - spin_lock_irqsave(&nbd->tasks_lock, flags);
> nbd->task_recv = current;
> - spin_unlock_irqrestore(&nbd->tasks_lock, flags);
It seems like task_{send,recv} are only used for the files showing
the pids. Maybe you should just store the pids directly in the
nbd_device structure and also keep the sysfs file around for the
life time of that structure.
Reply to: