Re: [Nbd] [PATCH] nbd: Fix timeout detection
- To: Markus Pargmann <mpa@...1897...>
- Cc: nbd-general@lists.sourceforge.net, kernel@...1897...
- Subject: Re: [Nbd] [PATCH] nbd: Fix timeout detection
- From: Hermann Lauer <Hermann.Lauer@...1489...>
- Date: Wed, 22 Apr 2015 10:26:20 +0200
- Message-id: <20150422082620.GB27189@...1490...>
- In-reply-to: <1429513167-28375-1-git-send-email-mpa@...1897...>
- References: <1429513167-28375-1-git-send-email-mpa@...1897...>
Hello All,
On Mon, Apr 20, 2015 at 08:59:27AM +0200, Markus Pargmann wrote:
> At the moment the nbd timeout just detects hanging tcp operations. This
> is not enough to detect a hanging or bad connection as expected of a
> timeout.
many thanks for the patch, which I tried on the jessie 3.16.7-ckt9 kernel
and vanilla 4.0:
linux-4.0> patch -p1 --dry-run <../patches/nbd-timeout.patch
patching file drivers/block/nbd.c
Hunk #1 FAILED at 59.
Hunk #2 succeeded at 133 (offset 12 lines).
Hunk #3 succeeded at 141 (offset 12 lines).
Hunk #4 succeeded at 196 (offset 12 lines).
Hunk #5 succeeded at 214 (offset 12 lines).
Hunk #6 FAILED at 399.
Hunk #7 succeeded at 499 (offset 21 lines).
Hunk #8 succeeded at 528 (offset 21 lines).
Hunk #9 succeeded at 537 (offset 21 lines).
Hunk #10 succeeded at 562 (offset 21 lines).
Hunk #11 succeeded at 686 (offset 21 lines).
Hunk #12 succeeded at 891 (offset 26 lines).
2 out of 12 hunks FAILED -- saving rejects to file drivers/block/nbd.c.rej
The same hunks fail on both trees, so my guess is that the patch is against
kernel/git/next/linux-next.git.
Will try that next - when a little spare time allows.
Thanks
greetings
Hermann
--
Netzwerkadministration/Zentrale Dienste, Interdiziplinaeres
Zentrum fuer wissenschaftliches Rechnen der Universitaet Heidelberg
IWR; INF 368; 69120 Heidelberg; Tel: (06221)54-8236 Fax: -5224
Email: Hermann.Lauer@...1489...
Reply to: