On Thu, Apr 02, 2015 at 02:05:34AM -0700, Christoph Hellwig wrote:
> On Thu, Apr 02, 2015 at 10:11:39AM +0200, Markus Pargmann wrote:
> > +/*
> > + * Forcibly shutdown the socket causing all listeners to error
> > + */
> > static void sock_shutdown(struct nbd_device *nbd, int lock)
> > {
> > - /* Forcibly shutdown the socket causing all listeners
> > - * to error
> > - *
> > - * FIXME: This code is duplicated from sys_shutdown, but
> > - * there should be a more generic interface rather than
> > - * calling socket ops directly here */
> > if (lock)
> > mutex_lock(&nbd->tx_lock);
> > if (nbd->sock) {
>
> Please also kill the conditional locking here in a future patch by
> moving it into the caller.
Yes, thanks. I will make a patch for that.
Best Regards,
Markus
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Attachment:
signature.asc
Description: Digital signature