Re: [Nbd] [PATCH 3/9] nbd: Remove kernel internal header
- To: Markus Pargmann <mpa@...1897...>
- Cc: nbd-general@lists.sourceforge.net, linux-kernel@...25...
- Subject: Re: [Nbd] [PATCH 3/9] nbd: Remove kernel internal header
- From: Wouter Verhelst <w@...112...>
- Date: Sat, 14 Feb 2015 11:30:24 +0100
- Message-id: <20150214103024.GF16027@...3...>
- In-reply-to: <1423774657-12748-4-git-send-email-mpa@...1897...>
- References: <1423774657-12748-1-git-send-email-mpa@...1897...> <1423774657-12748-4-git-send-email-mpa@...1897...>
On Thu, Feb 12, 2015 at 09:57:31PM +0100, Markus Pargmann wrote:
> The header is not included anywhere. Remove it and include the private
> nbd_device struct in nbd.c.
It exists mostly for the benefit of userspace trying to speak the NBD
protocol. I've stopped trying to depend on it (since nbd-server needs to
run on !Linux, too), but there are other implementations that might want
to use it.
nbd.h is part of a public API. Let's not drop it.
--
It is easy to love a country that is famous for chocolate and beer
-- Barack Obama, speaking in Brussels, Belgium, 2014-03-26
Reply to: