[Nbd] [PATCH 7/9] nbd: Remove fixme that was already fixed
- To: nbd-general@lists.sourceforge.net
- Cc: linux-kernel@...25...
- Subject: [Nbd] [PATCH 7/9] nbd: Remove fixme that was already fixed
- From: Markus Pargmann <mpa@...1897...>
- Date: Thu, 12 Feb 2015 21:57:35 +0100
- Message-id: <1423774657-12748-8-git-send-email-mpa@...1897...>
- In-reply-to: <1423774657-12748-1-git-send-email-mpa@...1897...>
- References: <1423774657-12748-1-git-send-email-mpa@...1897...>
The mentioned problem is not present anymore.
Signed-off-by: Markus Pargmann <mpa@...1897...>
---
drivers/block/nbd.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index 60a38b06a79b..3a3e0057e991 100644
--- a/drivers/block/nbd.c
+++ b/drivers/block/nbd.c
@@ -105,14 +105,11 @@ static void nbd_end_request(struct nbd_device *nbd, struct request *req)
spin_unlock_irqrestore(q->queue_lock, flags);
}
+/*
+ * Forcibly shutdown the socket causing all listeners to error
+ */
static void sock_shutdown(struct nbd_device *nbd, int lock)
{
- /* Forcibly shutdown the socket causing all listeners
- * to error
- *
- * FIXME: This code is duplicated from sys_shutdown, but
- * there should be a more generic interface rather than
- * calling socket ops directly here */
if (lock)
mutex_lock(&nbd->tx_lock);
if (nbd->sock) {
--
2.1.4
Reply to: