Re: [Nbd] nbd timeout on debian jessie (Was: Re: oops with timeout option on debian wheezy kernel)
- To: Michal Belczyk <belczyk@...1274...>
- Cc: nbd-general@lists.sourceforge.net
- Subject: Re: [Nbd] nbd timeout on debian jessie (Was: Re: oops with timeout option on debian wheezy kernel)
- From: Hermann Lauer <Hermann.Lauer@...1489...>
- Date: Tue, 18 Nov 2014 10:31:50 +0100
- Message-id: <20141118093150.GG20088@...1490...>
- In-reply-to: <20141114165219.GD28731@...1273...>
- References: <20140210120607.GI19189@...1490...> <20140211222008.GE95782@...1273...> <20141114161117.GC15362@...1490...> <20141114165219.GD28731@...1273...>
Hello Michal,
On Fri, Nov 14, 2014 at 05:52:19PM +0100, Michal Belczyk wrote:
> > reinvestigated this issue on debian jessie (kernel 3.16-3-amd64 #1 SMP Debian 3.16.5-1)
> > and still getting hangs - has the mentioned patch made his way upstream ?
> >
> > Looking at the 3.16.1 vanilla source at a first glance looks like it's not there - and
> > I seem to have no version which applys cleanly.
>
> IIRC this required some refactor for post 3.12 or 3.13 kernels...
> Please try the attached patch.
> This is the version rebased against the current tip, completely
> untested.
fails to compile on debian jessie kernel with:
/home/hlauer/kernel/linux-3.16.7/drivers/block/nbd.c: In function ‘nbd_send_req’:
/home/hlauer/kernel/linux-3.16.7/drivers/block/nbd.c:323:37: error: invalid type argument of ‘->’ (have ‘struct bio_vec’)
nbd->disk->disk_name, req, bvec->bv_len);
^
/home/hlauer/kernel/linux-3.16.7/drivers/block/nbd.c:47:46: note: in definition of macro ‘dprintk’
if (debugflags & (flags)) printk(KERN_DEBUG fmt); \
^
/home/hlauer/kernel/linux-3.16.7/scripts/Makefile.build:263: recipe for target 'drivers/block/nbd.o' failed
Replaced "bvec->bv_len" with "bvec.bv_len", now it compiles at least.
Why did this bugfix not made his way upstream (especially as this timeout issue is a blocker for mirroring) ?
Many thanks for working on this,
greetings
Hermann
--
Netzwerkadministration/Zentrale Dienste, Interdiziplinaeres
Zentrum fuer wissenschaftliches Rechnen der Universitaet Heidelberg
IWR; INF 368; 69120 Heidelberg; Tel: (06221)54-8236 Fax: -5224
Email: Hermann.Lauer@...1489...
Reply to: