Re: [Nbd] [PATCH 2/2] gznbd: fix warning with newer zlib
- To: Mike Frysinger <vapier@...103...>
- Cc: nbd-general@lists.sourceforge.net
- Subject: Re: [Nbd] [PATCH 2/2] gznbd: fix warning with newer zlib
- From: Wouter Verhelst <w@...112...>
- Date: Mon, 2 Dec 2013 14:13:34 +0100
- Message-id: <20131202131332.GA9230@...3...>
- In-reply-to: <1385961992-10114-2-git-send-email-vapier@...103...>
- References: <1385961992-10114-1-git-send-email-vapier@...103...> <1385961992-10114-2-git-send-email-vapier@...103...>
Both applied, thanks.
On Mon, Dec 02, 2013 at 12:26:32AM -0500, Mike Frysinger wrote:
> When you build against newer zlib, you get a lot of warnings like so:
>
> gznbd.c: In function 'main':
> gznbd.c:87:5: warning: assignment from incompatible pointer type [enabled by default]
> gznbd.c:109:5: warning: passing argument 1 of 'gzread' from incompatible pointer type [enabled by default]
> In file included from gznbd.c:37:0:
> /usr/include/zlib.h:1313:21: note: expected 'gzFile' but argument is of type 'struct gzFile_s **'
> gznbd.c:118:9: warning: passing argument 1 of 'gzerror' from incompatible pointer type [enabled by default]
>
> This is because the zlib API uses just gzFile everywhere, not a pointer
> to a gzFile.
>
> Signed-off-by: Mike Frysinger <vapier@...103...>
> ---
> gznbd/gznbd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gznbd/gznbd.c b/gznbd/gznbd.c
> index bb41156..803c1c1 100644
> --- a/gznbd/gznbd.c
> +++ b/gznbd/gznbd.c
> @@ -68,7 +68,7 @@ int main(int argc, char **argv)
> int pr[2];
> int sk;
> int nbd;
> - gzFile *gz;
> + gzFile gz;
> int gzerr;
>
> char chunk[CHUNK];
> --
> 1.8.4.3
>
>
> ------------------------------------------------------------------------------
> Rapidly troubleshoot problems before they affect your business. Most IT
> organizations don't have a clear picture of how application performance
> affects their revenue. With AppDynamics, you get 100% visibility into your
> Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
> http://pubads.g.doubleclick.net/gampad/clk?id=84349351&iu=/4140/ostg.clktrk
> _______________________________________________
> Nbd-general mailing list
> Nbd-general@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/nbd-general
>
--
This end should point toward the ground if you want to go to space.
If it starts pointing toward space you are having a bad problem and you
will not go to space today.
-- http://xkcd.com/1133/
Reply to: