Re: [Nbd] [PATCH 1/5] nbd-server: remove unused function
- To: Tuomas Jorma Juhani Räsänen <tuomasjjrasanen@...1258...>
- Cc: nbd-general@lists.sourceforge.net
- Subject: Re: [Nbd] [PATCH 1/5] nbd-server: remove unused function
- From: Wouter Verhelst <w@...112...>
- Date: Sat, 12 Jan 2013 12:46:54 +0100
- Message-id: <20130112114654.GA19603@...3...>
- In-reply-to: <20130111215347.GA1806@...1259...>
- References: <20130111215347.GA1806@...1259...>
thanks, applied.
On Fri, Jan 11, 2013 at 11:53:47PM +0200, Tuomas Jorma Juhani Räsänen wrote:
> Something like this might be needed in the future, once dynamic
> reconfiguration has landed. But it's better to rewrite and test it then
> and not keep unreferenced code hanging around cluttering the code base.
>
> Signed-off-by: Tuomas Jorma Juhani Räsänen <tuomasjjrasanen@...1261...>
> ---
> nbd-server.c | 21 ---------------------
> 1 file changed, 21 deletions(-)
>
> diff --git a/nbd-server.c b/nbd-server.c
> index 0e54759..abb647c 100644
> --- a/nbd-server.c
> +++ b/nbd-server.c
> @@ -643,27 +643,6 @@ typedef enum {
> } SETUP_ERRORS;
>
> /**
> - * Remove a SERVER from memory. Used from the hash table
> - **/
> -void remove_server(gpointer s) {
> - SERVER *server;
> -
> - server=(SERVER*)s;
> - g_free(server->exportname);
> - if(server->authname)
> - g_free(server->authname);
> - if(server->listenaddr)
> - g_free(server->listenaddr);
> - if(server->prerun)
> - g_free(server->prerun);
> - if(server->postrun)
> - g_free(server->postrun);
> - if(server->transactionlog)
> - g_free(server->transactionlog);
> - g_free(server);
> -}
> -
> -/**
> * duplicate server
> * @param s the old server we want to duplicate
> * @return new duplicated server
> --
> 1.7.10.4
>
>
> ------------------------------------------------------------------------------
> Master HTML5, CSS3, ASP.NET, MVC, AJAX, Knockout.js, Web API and
> much more. Get web development skills now with LearnDevNow -
> 350+ hours of step-by-step video tutorials by Microsoft MVPs and experts.
> SALE $99.99 this month only -- learn more at:
> http://p.sf.net/sfu/learnmore_122812
> _______________________________________________
> Nbd-general mailing list
> Nbd-general@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/nbd-general
--
Copyshops should do vouchers. So that next time some bureaucracy requires you
to mail a form in triplicate, you can mail it just once, add a voucher, and
save on postage.
Reply to: